jplana / python-etcd

A python client for etcd
Other
523 stars 210 forks source link

Yield self only if requested when there are no children #156

Closed khenderick closed 8 years ago

khenderick commented 8 years ago

When there are no children, self is yielded even though the leaves_only parameter is True when you use my_result.children.

khenderick commented 8 years ago

Based on the failed tests, a lot of code depends on this - imo incorrect - behavior. Unfortunately, I don't have the time to look into it further, so I'll close of this pull request with a +1 towards #155 and we'll work around this in our wrapper.