Fix incompatibility with etcd 3: don't set TLSv1 protocol in the client

jplana / python-etcd

A python client for etcd

Other

522 stars 210 forks source link

Fix incompatibility with etcd 3: don't set TLSv1 protocol in the client #196

Closed fasaxc closed 8 years ago

fasaxc commented 8 years ago

Calico users have been seeing incompatibility with etcd v3 (https://github.com/projectcalico/calico-containers/issues/1107), because specifying TLSv1 explicitly prevents urllib3 from negotiating a newer version of the protocol.

This change was recommended by @lukasa, who is one of the maintainers of urllib3: https://github.com/projectcalico/python-etcd/issues/16.

fasaxc commented 8 years ago

@lavagetto @jplana Do you have an IRC or slack to discuss changes? I could probably host one on the calico-users public slack if that'd be helpful.

coveralls commented 8 years ago

Coverage decreased (-0.05%) to 88.181% when pulling 80f936963773053c36ebdff5185147b5e127f94d on projectcalico:remove-tls-option into 3d061310094062a479ec0bfe69ca04471332e2d9 on jplana:master.

lavagetto commented 8 years ago

@fasaxc Sorry I have been running around a lot and very busy at work. I'd probably prefer IRC over slack, but hosting a slack your public slack would be fine, I guess :)

fasaxc commented 8 years ago

@lavagetto @jplana I created #python-etcd on Freenode