search

jplana / python-etcd

A python client for etcd
Other
520 stars 210 forks source link

Lock must take into account modifiedIndex of locker #206

Closed ainlolcat closed 7 years ago

ainlolcat commented 7 years ago
  1. etcd.lock.Lock#_get_locker now returns not just lock path but whole node with modifiedIndex inside to watch changes starting from it.
  2. fix tests which expected only string with path
ainlolcat commented 7 years ago

Issue https://github.com/jplana/python-etcd/issues/181

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 88.212% when pulling 73cbfb127417bbc34d8ebbd4f8106818b0373914 on ainlolcat:master into 0d0145f5e835aa032c97a0a5e09c4c68b7a03f66 on jplana:master.

Oloremo commented 7 years ago

Waiting for this fix...

ainlolcat commented 7 years ago

Sorry to bother but can we get release of python-etcd with this fix anytime soon? @lavagetto @jplana

jplana commented 7 years ago

I'll be looking into it no later than this week, along with some other PRs long stuck in the queue.

El mié., 11 ene. 2017 a las 12:01, ainlolcat (notifications@github.com) escribió:

Sorry to bother but can we get release of python-etcd with this fix anytime soon? @lavagetto https://github.com/lavagetto @jplana https://github.com/jplana

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/jplana/python-etcd/pull/206#issuecomment-271840306, or mute the thread https://github.com/notifications/unsubscribe-auth/AAkdB62iKbHkzr04QUWOlBBdS76F_pg7ks5rRLZ_gaJpZM4Kj5gV .

ainlolcat commented 7 years ago

Thank You. Looking forward to it.

jplana commented 7 years ago

Thanks a lot for the fix! I'll be releasing this ASAP!