search

jplana / python-etcd

A python client for etcd
Other
520 stars 210 forks source link

Change default client port to 2379 #211

Closed soumyadipdm closed 7 years ago

soumyadipdm commented 7 years ago

Per newer releases of etcd, 2379 is the default port for client traffic. Refer: https://github.com/coreos/etcd/blob/release-3.0/etcd.conf.yml.sample#L29

etcd.Client still uses old port 4001 as the default, which means it cannot be used out of the box.

ashcrow commented 7 years ago

:+1: to the idea. However, there will still be a lot of people on v2 for a while. I'm not sure if @jplana is expecting to update to v3 as the default for testing or not.

lavagetto commented 7 years ago

This would break backwards compatibility and the running code of a lot of people.

I would want to do this myself but we cannot really break other people's code like this.