search

jplana / python-etcd

A python client for etcd
Other
520 stars 210 forks source link

DNS SRV support problem---srv_name convention #253

Closed europelee closed 10 months ago

europelee commented 6 years ago

code in client.py: def _discover(self, domain): srv_name = "_etcd._tcp.{}".format(domain) ... ... please refer to https://coreos.com/etcd/docs/latest/v2/clustering.html#dns-discovery there exists two types of DNS discovery configuration convention: like _etcd-server._tcp.example.com, _etcd-client._tcp.example.com for etcd client, we need discovering the etcd cluster, so we use _etcd-client._tcp.example.com. It is better that use _etcd-client._tcp.{} instead of _etcd._tcp.{}, or "_etcd-client._tcp" can be used as optional input paramter of client(i.e default prefix dns srv record is "_etcd._tcp").

zloyded commented 3 years ago

this project look like a rotten corps.