search

jplatte / cargo-depgraph

Creates graphviz dependency graphs for Rust projects that use Cargo
GNU General Public License v3.0
151 stars 8 forks source link

Update Cargo.lock for 1.6.0 #20

Closed orhun closed 9 months ago

orhun commented 9 months ago

I would suggest setting up a CI (e.g. GitHub Actions) and build with --locked flag to avoid this :)

edit: happy to contribute if you want to go with GitHub Actions

jplatte commented 9 months ago

Hm, I haven't used CI-based publish workflows before and am a little wary about them.

Also I need to re-think how I handle this project overall, it's currently dual-hosted on git.sr.ht and GitHub and has no CI at all, which is also rather weird for accepting external contributions 😅

How about this: I want to try out codeberg.org's CI soon anyways, if I don't like it I'll create an initial GitHub Actions CI workflow myself for PRs, and then ping you about the release workflow.

orhun commented 9 months ago

Sounds good! - Just to clarify: what you can do is to use --locked flag for the CI, not the release workflow. But it can be a part of the release workflow as well for sure.

jplatte commented 9 months ago

Ah, well I didn't even make a PR at all when bumping the version, so there was no CI that would have been able to catch the error (prior to releasing). But I'll keep this in mind for future CI workflows to use --locked when there is a lockfile.

jplatte commented 9 months ago

Alright, I've now added a branch protection that applies even to myself and forces me to go through the PR procedure to push stuff to the main branch. CI config is here, feel free to suggest improvements! Test job is commented out because I don't have any tests yet 🥲

orhun commented 9 months ago

Great, applied some suggestions in #21