search

jplatte / turbo.fish

::<> ⠀ https://turbo.fish/ ⠀ <>::
GNU Affero General Public License v3.0
631 stars 8 forks source link

More exciting and exotic types #7

Closed xeniagda closed 6 years ago

xeniagda commented 6 years ago

I thought the types the random button generated were a little bit boring so I added some more, nested types

jplatte commented 6 years ago

Hi! Thanks for taking the time to create a PR for this silly website :smile:

Code looks good, except I think it would be good to remove the potential infinite recursion (that is, don't use generic types as type arguments for other generic types) – there's already an issue on narrow screens that kind of ruins the animation and having very long type names would make it worse. Also, it would be nice if you could squash your commits.

xeniagda commented 6 years ago

The commits are squashed and the types have a maximum recursion limit of two nested types (such as Result<Vec<_>, _>. Is there anything else to consider before merging?

jplatte commented 6 years ago

Is there anything else to consider before merging?

Nope.

Thanks! :)

jplatte commented 6 years ago

Whoops, wrong button :man_facepalming:

jplatte commented 6 years ago

I hate GitHub. Rebasing still changes the committer even if the rebase is a no-op.

jplatte commented 6 years ago

So I don't have any automatic deployment in place, if you're wondering why the changes aren't reflected on the website. I'll deploy in the next few days.