jplattel / obsidian-clipper

A Chrome extension that easily clips selections to Obsidian
https://jplattel.github.io/obsidian-clipper/
733 stars 60 forks source link

Cannot create clipping with certain characters in title #53

Open phubers opened 2 years ago

phubers commented 2 years ago

When trying to clip from a webpage with "|" in the title, obsidian-clipper does not strip illegal characters from the file name, resulting in an error message in Obsidian (and no clip).

sometxdude commented 2 years ago

I have a similar issue when using {title}. Is there anyway to strip illegal filename characters from {title}?

cagataykiyici commented 1 year ago

Unfortunately, pipe character ("|") is commonly used in web page titles. Bugfix should also include other forbidden characters which may also be used in page titles.

Therefore, only solution till this is fixed is omiting {title} from config or manualy clip such pages.

Flashwalker commented 1 year ago

Some characters breaks clipping. Firstly i thought it was limit for characters amount. But looks like certain characters breaks clipping. Looks like the author forgot to url-encode the clipping content

Flashwalker commented 1 year ago

I made a userscript obsidian-webclip-as-markdown.user.js that clipps ok.
There is no need for remote 3rd party services for this

iHeadway commented 1 year ago

There is no need for remote 3rd party services for this

It doesn't clip images or I'm doing something wrong.

Flashwalker commented 1 year ago

There is no need for remote 3rd party services for this

It doesn't clip images or I'm doing something wrong.

give me please the url you are clipping

iHeadway commented 1 year ago

give me please the url you are clipping

It's a site I tried first: https://learn.microsoft.com/en-us/windows/package-manager/winget/upgrade markdownload also has the problem with images there.

Flashwalker commented 1 year ago

https://learn.microsoft.com/en-us/windows/package-manager/winget/upgrade

i see now I just haven't implemented image clipping yet, it needs to be done. (Actually it will just by https url)

Flashwalker commented 1 year ago

give me please the url you are clipping

It's a site I tried first: https://learn.microsoft.com/en-us/windows/package-manager/winget/upgrade markdownload also has the problem with images there.

Just updated. Now images will be displayed by Obsidian via http url obsidian-webclip-as-markdown.user.js

iHeadway commented 1 year ago

@Flashwalker Any chances to have a version without characters limit in the future? 🙂

Flashwalker commented 1 year ago

@Flashwalker Any chances to have a version without characters limit in the future? slightly_smiling_face

need time to research