search

jplayer / jPlayer

jPlayer : HTML5 Audio & Video for jQuery
http://jplayer.org/
Other
4.6k stars 1.47k forks source link

user-agent opera regular expression need modifying #172

Open easywaru opened 11 years ago

easywaru commented 11 years ago

jplayer opera's regular expression like down. var ropera = /(opera)(?:.*version)? \//;

my opera has user-agent like down. "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/28.0.1500.95 Safari/537.36 OPR/15.0.1147.153"

opera's user-agent is change from Opera to OPR.

happyworm commented 11 years ago

Suppose it could be worse, at least they did not put MSIE in there too. While the opera rule is now wrong for those upgraded to Opera 15+, it is Chrome that would also be a false positive... Maybe even Safari. It's a good job we do not care about that and its only msie that makes a difference for the SWF insertion code. Hmmm... I think we do have 1 switch for Chrome, since I found a bug that could crash chrome ages ago, that they have not fix... could crash chrome in under a tweet :8ball:

I personally hate the UA sniffing in jPlayer, but I could not see any sensible way to feature detect where I did end up using it.

thepag commented 10 years ago

I may well investigate a 3rd party jQuery plugin for the browser sniffer. That was the idea when jQuery removed it, I just do not know it anyone made a decent one.