jplayer 2.7 not working on Android - workaround here, but fix needed.

jplayer / jPlayer

jPlayer : HTML5 Audio & Video for jQuery

http://jplayer.org/

Other

4.6k stars 1.47k forks source link

jplayer 2.7 not working on Android - workaround here, but fix needed. #241

Closed ghost closed 9 years ago

ghost commented 9 years ago

There's a lively thread on the group at https://groups.google.com/d/msg/jplayer/BoVUNok0yl4/LU8q2wggQaYJ regarding jplayer not working on Android. There is also a workaround supplied which is to comment out

    //self.androidFix.setMedia = true;

however I guess that function does something else, too. So flagging it up here for review rather than doing a pull request. All thanks to Cyril for finding a workaround.

smidgen commented 9 years ago

Isn't that workaround going to break any other Android browsers that need the "android fix"?

smidgen commented 9 years ago

I made a pull request: https://github.com/happyworm/jPlayer/pull/242 as a potential solution.

robinhh commented 9 years ago

Isnt't this fixed with release 2.7.1?

ghost commented 9 years ago

Looks like this HAS now been fixed with v2.7.1 on Github - you can download the file here: https://raw.githubusercontent.com/happyworm/jPlayer/master/jquery.jplayer/jquery.jplayer.js

Given that this affects so many users, it's unfortunate that this isn't on the main download site.

The good news is that it's available all nice and compressed on cdnjs - just link to this: http://cdnjs.cloudflare.com/ajax/libs/jplayer/2.7.1/jquery.jplayer/jquery.jplayer.min.js

robinhh commented 9 years ago

Thanks for the clarification! (I was just wondering because this issue is still open)

ghost commented 9 years ago

Good point! I forgot that as I opened it, I have the power to close it. Closed - thanks jplayer team and original bug finders and fixers! :+1:

ghost commented 9 years ago

I'm re-opening this until the 2.7.1 version makes it onto the live site, as the inability to play on Android appears to be affecting a significant number of users both on the group as well as elsewhere.

erewok commented 9 years ago

I am actually finding 2.7.1 to be a bit unreliable on Android 4.4.4 with Chrome 37 (but not Firefox 32). There are long delays to getting mp3 streams to start, and these are not present in jPlayer 2.6.4.

thepag commented 9 years ago

FYI: I am currently moving jPlayer to be self contained in the repo. All the website will do is latest demos and docs. It ill point you at the repo for all downloads. ATM, you can see my work in progress in the dev branch.

mlissner commented 9 years ago

I deployed jplayer last week with 2.7.0 and this week somebody is reporting that it doesn't work on Android. Would be great to get the merge of the download pages all wrapped up soon so others don't fall into this void.

thepag commented 9 years ago

This issue was fixed in 2.7.1 The website is now secondary to this repo. This repository is now the primary source of all jPlayer files. The website is simply the online demos of the latest version, along with its docs and guides.

This problem should never happen again.

Closing thread this with my humble apologies for the confusion.

mlissner commented 9 years ago

Lovely, thank you! Long live the repository.