search

jplayer / jPlayer

jPlayer : HTML5 Audio & Video for jQuery
http://jplayer.org/
Other
4.6k stars 1.47k forks source link

Adds an option to supply a backup duration value #249

Closed jeffrvw closed 9 years ago

jeffrvw commented 9 years ago

Adds an option to supply a backup duration value for calculation/display in _getHtmlStatus, for use in case of incompatible and immutable file service (noted in FAQ item "Why do my progress bars not work in Chrome?")

thepag commented 9 years ago

The duration may be given in the setMedia object. Rejecting this PR due to duplication of existing feature. (I guess my docs need improving. That feature is a little hard to spot in the setMedia docs.)

duration String : [optional] Explicitly defines the displayed duration Number : [optional] Defines the displayed duration of the media

FYI, using a number is best... You can do maths on numbers, while "1:32" would need parsing and they can do that themselves if they want and give us the number in seconds. The duration display options also work seamlessly with a number given here.

jeffrvw commented 9 years ago

Thanks for the clarification, @thepag! Obviously I didn't spot that, but I see it now. Great work all-around, and thank you - you'll find it in use here: http://www.skullcandy.com/drop-in/meet-dorothy/ with a little accessory wrapper I built to allow content authors to add simple players with one line of markup.

thepag commented 9 years ago

FYI, I got 404 error in the main area... Menus and such on the top and left, then 404 where I imagine the player should be... Unless I missed the point.

Your wrapper sounds like: https://github.com/happyworm/jPlayer.injector

The dev branch is the best part there... Making a polyfill for HTML5 using jPlayer.

jeffrvw commented 9 years ago

Very interesting on the 404, thanks for the feedback - guessing it's because you're hitting it from outside the US, but ideally it shouldn't be broken...

Wrapper is very similar in effect, just narrowly defined for the case at hand (http://demandware.edgesuite.net/aalz_prd/on/demandware.static/Sites-SKDYUS-Site/Sites-SKDYUS-Library/default/v1415112071516/content_assets/DROP_IN/slimplayer.js).