search

jplayer / jPlayer

jPlayer : HTML5 Audio & Video for jQuery
http://jplayer.org/
Other
4.6k stars 1.47k forks source link

fullscreen support #250

Closed aboutqx closed 9 years ago

aboutqx commented 9 years ago

it seems that jplayer is not supported for fullscreen in IE. need somthing like this
// Microsoft [ 'msFullscreenEnabled', 'msFullscreenElement', 'msRequestFullscreen', 'msExitFullscreen', 'MSFullscreenChange', 'MSFullscreenError' ] is that right? code from video.js

Afterster commented 9 years ago

I think it is related/duplicate with https://github.com/happyworm/jPlayer/pull/213 pull request, but this PR is not merged yet. jPlayer maintainer doesn't review PR frequently (some are years old without any feedback...) so lets hope it will be merged one day :)

aboutqx commented 9 years ago

thanks for reminding

thepag commented 9 years ago

I'm reviewing. Our notifications seem to be different since changing the repo to an organisation.

Some PR are years old and left there since they are obscure stuff that might benefit someone. You are right tho. I will clean out any PR or issue that is either obsolete, left there to help others, or just wrong.

Unfortunately, we need to get a CLA in place before we can accept any more PRs.

As for the topic... I'll review M$ full screen. At the time I added FS to jPlayer, Ie was sill in the land of Press F11 and it goes full screen BS.

aboutqx commented 9 years ago

well,i believe you're solving the problem.Jplayer is a good job,especially it's open source project. By the way ,i like your portrait very much.

thepag commented 9 years ago

OK, I've figured out my notification problem. When I changed my happyworm account to an organisation, I'd forgotten to watch the happyworm/jPlayer repository from my new thepag account.

I am in the middle of a large refactor of the jPlayer repo (in the dev branch) and in turn the website. My aim is to make a single point of download... Like this 2.7.0 to 2.7.1 update... I want that to simply never happen again by removing the duplication with the main jplayer.org site. Well that, and also bring in some awesome new ARIA compliance. I hope to take a look at this after performing that.

WRT my avatar, that is my game face. I should make a less manic one for use here. Thx.

Afterster commented 9 years ago

Thanks for your response @thepag. It's good to know awesome changes are coming and that CLA was the missing piece slowing down pull request merge. I saw the CLA.md file was updated, I think you know about https://www.clahub.com / https://github.com/clahub/clahub for better CLA integration on pull request (sorry for the thread hijack)?

thepag commented 9 years ago

Thank you for the tip @Afterster I have now setup CLAhub on the jPlayer repo. We have a CLA.md in the repo that has the same text as the clahub text. I also added the CONTRIBUTING.md file, which I understand will guide users through the process when they make a PR.

I will be updating that doc (CONTRIBUTING.md) with more guidelines on code style and the PR itself, but will do that later. I can do the PRs through my own local branch if I do not want everything going directly into the master branch.

Last week I got the new website sorted out. It looks the same, but under the hood it should be easier for me to maintain in future. The website will be a demo and docs site and here in github will be everything you need.

Thx for patience.

thepag commented 9 years ago

Closing this thread, since once the CLA issue is sorted out I will be merging in #213 pull request.