search

jplayer / jPlayer

jPlayer : HTML5 Audio & Video for jQuery
http://jplayer.org/
Other
4.6k stars 1.47k forks source link

CommonJS support #257

Closed nervo closed 9 years ago

thepag commented 9 years ago

I take it that exports is a global var in commonJS, like define is with AMD? I'll be reviewing that, and only ask since I'll need to add that to the jshint options.

nervo commented 9 years ago

Something like that, yes. Have a look on this https://github.com/umdjs/umd

thepag commented 9 years ago

You need to sign the CLA please.

thepag commented 9 years ago

Yeah, I looked into it and added the require global to the .jshintrc list of globals.

thormeier commented 9 years ago

Thanks for merging! Already installed 2.9 via composer :) By the way, have you considered registering jPlayer on https://packagist.org/ as suggested in the initial PR?

thepag commented 9 years ago

I think you mean PR #235 @thormeier.