ARIA controls don't work

jplayer / jPlayer

jPlayer : HTML5 Audio & Video for jQuery

http://jplayer.org/

Other

4.6k stars 1.47k forks source link

ARIA controls don't work #283

Closed ghost closed 9 years ago

ghost commented 9 years ago

Controlling playback with keyboard no longer works (Arrow keys and space, at least). These keys were removed in commit 616569799c7cb52f49b218e7257605e3b95f77b5 but ARIA should enable them, right?

Version: 2.9.0 Browser: Iceweasel (Firefox) 31.3.0

ghost commented 9 years ago

Bump

thepag commented 9 years ago

The migration log and change log hold info on this change: https://github.com/happyworm/jPlayer/blob/master/MIGRATION.md

The keys were changed, since space and arrow keys are supposed to be reserved for ARIA operations.

thepag commented 9 years ago

The documentation had also been updated... http://jplayer.org/latest/developer-guide/#jPlayer-option-keyBindings

ghost commented 9 years ago

Indeed. It seems I misunderstood how ARIA should work (These keys are reserved for std navigation).