jplayer / jPlayer

jPlayer : HTML5 Audio & Video for jQuery
http://jplayer.org/
Other
4.6k stars 1.47k forks source link

Fullscreen keyboard shortcut disable control F search in chrome #290

Open onigetoc opened 9 years ago

onigetoc commented 9 years ago

Hi, i do not want the fullscreen F or Control F but it lock the search in brower in Chrome.

i set fullScreen: fullWindow: and audioFullScreen to false but when the audio is a m4a it think it's a video. if i do control F in Chrome the search still not work and i got a fullscreen black window.

Everytime i want to do a search in page using conctrol F in chrome. i alway forget that jplayer will open a black fullscreen and if i disable fullscreen the search window in chrome will not appear.

thepag commented 9 years ago

Yes this is a problem.

With audio, I only see the search not working - no black screen. But the F key is being captured. I'll probably change the key to something else. Or you can easily if you get the option correct.

The video is a larger problem. Again, it will come down to changing the key, or possibly adding in extra level of key control to ensure that the metakey is not pressed.

thepag commented 9 years ago

Change the fullscreen key using the options: http://jplayer.org/latest/developer-guide/#jPlayer-option-keyBindings

I grab the key code from the jQuery page: http://api.jquery.com/event.which/

You could change it to 83 for the s key... How often do people control+S to save a webpage?

onigetoc commented 9 years ago

Thank you for your answer, i will check it

hrmoh commented 7 years ago

Same issue is seen on Firefox. I think due to frequent use of Ctrl+F on pages this shortcut should be changed in the main source.