search

jplayer / jPlayer

jPlayer : HTML5 Audio & Video for jQuery
http://jplayer.org/
Other
4.6k stars 1.47k forks source link

RFC: Replace sass with node-sass? #350

Open starlocke opened 8 years ago

starlocke commented 8 years ago

I was doing my own builds of jPlayer to learn more about its inner workings, and I noticed that sass was required to compile the CSS.

Since this project requires Grunt, and by that, requires Node/npm - would it be acceptable to migrate the project to node-sass instead of keeping the original ruby-based sass? My idea in suggesting this is to simplify the technical background needed to build jPlayer by consolidating within the npm ecosystem.

node-sass: https://github.com/sass/node-sass

npm install node-sass

Fun fact: Renaming node-sass to sass has been good (it compiles). I don't know if it compiles the same output as standard issue sass though.

vlinder commented 8 years ago

To simplify the building of jPlayer I made a pull request that introduced a Vagrantfile. Then every build would be made on a machine that looks the same for everyone. #296 Unfortunately it has not been merged in over a year..