Fix issue #281 - Githubissues

jplayer / jPlayer

jPlayer : HTML5 Audio & Video for jQuery

http://jplayer.org/

Other

4.6k stars 1.47k forks source link

Fix issue #281 #365

Open Phyks opened 8 years ago

Phyks commented 8 years ago

Aurora.JS is buggy

The logic behind the .desired attribute setter was broken. I fixed it and jPlayer should now be able to switch between Aurora, HTML and Flash backends automatically.

Closes #281.

EDIT: As far as I understood, this should be ok for a PR, and I should not include a minified version. Let me know if I missed something.

Phyks commented 8 years ago

Is this repo still active or should I consider forking and maintaining my fork? Issues such as the one fixed in this PR can be really blocking for some applications =(

Thanks!

ghost commented 7 years ago

~~fixes opera not play mp3 with solution: "html, flash",~~

guess its was something else, not sure what was doing before, but editing code in those lines made it work...

thedumbtechguy commented 7 years ago

Please fork and maintain. I don't think this repo is still active.

Do you think this patch will fix the issue on chrome with solution: "flash,html". Since NPAPI was disabled this doesn't work on chrome anymore.