search

jplayer / jPlayer

jPlayer : HTML5 Audio & Video for jQuery
http://jplayer.org/
Other
4.6k stars 1.47k forks source link

Improved volume control #374

Closed mdingena closed 7 years ago

mdingena commented 7 years ago

Changed from linear to logarithmic volume control. You will notice that the silent end of the volume bar is now less sensitive, and the loud end of the volume bar is now more sensitive. This source explains why linear volume control is bad and why logarithmic is awesome: http://dr-lex.be/info-stuff/volumecontrols.html Make jPlayer more awesome, use this PR.

maboa commented 7 years ago

Hi mdingena - sorry for the delay in replying.

Thanks for your very cool logarithmic volume control.

We're just starting to build up steam again. In order to merge your PR can you please approve the CLA http://jplayer.org/cla/ ?

Cheers

Mark B

maboa commented 7 years ago

Actually this might be easier https://www.clahub.com/agreements/happyworm/jPlayer

mdingena commented 7 years ago

I've signed it.

maboa commented 7 years ago

Thanks so much mdingena, I've merged but for backwards compatibility reasons we may decide to have an option for logarithmic volume control and have it turned off by default. This is what we usually do for features like this.

mdingena commented 7 years ago

That's fine. Happy to contribute! I've been using jPlayer for many years now with a custom skin and my sortable playlists hack #357. Take a look at that PR. It's jQuery specific though and I believe you guys want to go framework independent. But it might be enough to spark your interest or to put it on the roadmap for native jPlayer support. You can see my version of jPlayer in action at www.tjoonz.com </blatant self-promotion>