search

jpmcb / prow-github-actions

Slash commands, jobs, and chat-ops for Github actions inspired by Kubernetes Prow ⚓️
MIT License
92 stars 10 forks source link

Support OWNERS files #44

Closed carolynvs closed 2 years ago

carolynvs commented 2 years ago

Is your feature request related to a problem? Please describe. I want to specify exactly who can provide reviews and approve pull requests since there are a lot of people in the organization who do not qualify as reviewers and approvers.

Describe the solution you'd like I'd be happy with any way to specify a named set of people or teams that can be reviewers and approvers. Either by reading the OWNERS file (like prow does), or something more simple like just passing the action a list of names in the workflow file. I realize the full logic of owners files is pretty complex, and I just care about having a bit more control than just org membership.

Describe alternatives you've considered N/A

Additional context I'm happy to submit a PR for this if this is a welcome feature.

jpmcb commented 2 years ago

Thanks for opening this feature request! I think this is a great idea.

Either by reading the OWNERS file (like prow does)

I think that's the way to go on this but we could also do something simple in the action yaml file too.

I'm happy to accept a PR on this! 🚀

carolynvs commented 2 years ago

Excellent, I'll work on it this weekend.