search

jpmcgrath / shortener

Shortener makes it easy to create shortened URLs for your rails application.
MIT License
539 stars 223 forks source link

Add support for rails6 #127

Closed fschwahn closed 4 years ago

fschwahn commented 4 years ago

This PR includes several fixes for the tests, as well as a fix for the last remaining deprecation warning in rails6. I removed the initializer responsible for loading the view-helper, as it is unnecessary. I added a spec which tests that the helper is available in the main app.

fschwahn commented 4 years ago

It seems travisci doesn't work anymore.

natevick commented 4 years ago

@jpmcgrath @craigmcnamara any chance this could be merged?

jpmcgrath commented 4 years ago

Thanks for your contribution @fschwahn. It is much appreciated as is your patience. Your PR has been merged and released as v0.8.1 of the gem.