Use browser or crawler_detect gem instead of Voight-Kampff gem

jpmcgrath / shortener

Shortener makes it easy to create shortened URLs for your rails application.

MIT License

539 stars 225 forks source link

Use browser or crawler_detect gem instead of Voight-Kampff gem #151

Closed v-kumar closed 1 year ago

v-kumar commented 2 years ago

This gem uses https://github.com/biola/Voight-Kampff for bot detection. This gem has not been updated in 3 years and is not Ruby 3.0 incompatible. Several PRs and issues have been pending there unaddressed for a long time.

Use the more popular browser or [crawler_detect[(https://github.com/loadkpi/crawler_detect) for the same functionality.

We recently upgraded to ruby 3.0.3, and File.exists? deprecation warning from kampff gem are flooding the logs.

v-kumar commented 2 years ago

Any comments @jpmcgrath ?

jpmcgrath commented 2 years ago

Hi there. This seems like a reasonable proposition. I would welcome a pull request (with appropriate specs) to migrate to a better maintained dependency.

Blayr commented 1 year ago

@jpmcgrath I've made a PR to upgrade Voight-Kampff to a ruby 3 compatible version (2.0) https://github.com/jpmcgrath/shortener/pull/158