search

jpmcgrath / shortener

Shortener makes it easy to create shortened URLs for your rails application.
MIT License
539 stars 225 forks source link

Typo in documentation expirable URLs #153

Closed gaeduron closed 2 years ago

gaeduron commented 2 years ago

Hello, I just stumbled on to this while trying the library.

When using:

 Shortener::ShortenedUrl.generate("example.com/page", nil, expires_at: 24.hours.since)

There is a Too many argument error, got 2 expecting 1

I think we can omit the owner completely at line 166, like so:

You can omit owner:

Shortener::ShortenedUrl.generate("example.com/page", expires_at: 24.hours.since)
fschwahn commented 2 years ago

Thanks for fixing this!

gaeduron commented 2 years ago

Thank you for the lib and the quick response :) !