Closed DenniZr closed 7 years ago
No it's not necessary. I just need to merge it into master.
But let me just test a little more and think if this is the correct way of handling downlinks. I find this solution nice and simple, but I need to think about and test confirmed uplinks too.
What makes me think twice about how it is done now is that you always need to do a hasRX()
after every TX. On the one hand this is a simple and understandable solution, which makes the library usable to more people, but a more elegant solution would be if the TX function returned a status.
For example at the moment tx()
returns a false
if the transmission was unsuccessful. And it returns true
if it was successful and/or a acknowledgement was received. False is the same as 0, and true is a positive number. If we return a 1 for successful transmission and a 2 for successful transmission with data received, it could work well.
But as I said I need to think which way will be the best. I'd rather do it correctly now than changing the API later.
The TX functions now return one of three enum values:
Should i do anything else? New to github