Added custom DevEUI if wanted and Debug information if needed

jpmeijers / RN2483-Arduino-Library

Arduino C++ code to communicate with a Microchip RN2483 module

Apache License 2.0

84 stars 60 forks source link

Closed hallard closed 7 years ago

hallard commented 7 years ago

Added custom DevEUI if wanted instead using the hardware one from RN2xx3 module
Centralized some _Serial to sendRawCommand (easier for debugging serial transmission between RN2xx3 module and arduino)
Added initOTAA(uint8_t AppEUI, uint8_t AppKey, uint8_t * DevEUI) from uint8_t buffer

jpmeijers commented 7 years ago

What is the reason/use case that you need to set a custom DevEUI and not use the hardware EUI of the RN2483?

I like a lot of the things you added. But we need to clean up a little.

Some of the comments are wrong.
In some places F() is used for string constants, other places not. We need to make it consistent.
We need to decide if the uint8_t buffer init function is necessary. TTN dropped this from their library.

hallard commented 7 years ago

Guys, I've just updated this PR with your suggestions