jpmeijers / RN2483-Arduino-Library

Arduino C++ code to communicate with a Microchip RN2483 module
Apache License 2.0
84 stars 60 forks source link

Fixed bug in longitude EW, see https://github.com/SodaqMoja/Sodaq_UBl… #24

Closed jwillemsen closed 7 years ago

jwillemsen commented 7 years ago

…ox_GPS/pull/2

* examples/SodaqOne-TTN-Mapper-ascii/Sodaq_UBlox_GPS.cpp:
* examples/SodaqOne-TTN-Mapper-binary/Sodaq_UBlox_GPS.cpp:
* examples/SodaqOneAccelerometer/Sodaq_UBlox_GPS.cpp:
* examples/SodaqOneSimpleBicycleTracker/Sodaq_UBlox_GPS.cpp:
jpmeijers commented 7 years ago

Ahh great. This will explain some wrong measurements on TTN Mapper. Thanks for patching downstream!

Any way you know of to link directly to the upstream repo? Although the GPS library does not belong together with the RN2xx3 library, it is still necessary for the examples to work. Keeping them separate will be great, but then running the examples will get more complicated.

jwillemsen commented 7 years ago

Maybe git submodules could work but haven't used that myself