search

jpmeijers / RN2483-Arduino-Library

Arduino C++ code to communicate with a Microchip RN2483 module
Apache License 2.0
84 stars 60 forks source link

Implemented support for reading SNR + fixes #40

Closed SloMusti closed 7 years ago

SloMusti commented 7 years ago

Added the code to read the last packets SNR, which can be useful for debugging on the device side.

jpmeijers commented 7 years ago

The commit looks good, but I am wondering about the function's name. Functions like sysver and hweui return static values. An example of a function that returns info about the last packet, is getRx.

Should we not call this function getSnr? Or should we perhaps rename getRx to just received or something?

SloMusti commented 7 years ago

I see your point, however for the sake of backwards compatibility, it would be best to rename to getSNR.