Encoding error in TheThingsUno-GPSshield-TTN-Mapper-binary.ino example

jpmeijers / RN2483-Arduino-Library

Arduino C++ code to communicate with a Microchip RN2483 module

Apache License 2.0

86 stars 60 forks source link

Closed testert1ng closed 6 years ago

testert1ng commented 6 years ago

The encoding part for hdop looks not correct in TheThingsUno-GPSshield-TTN-Mapper-binary.ino example.

As the decoder part dividing by 10, the encoder should multiply by 10.

// should be multiplication (*) here
hdopGps = gps.hdop.value()/10;

jpmeijers commented 6 years ago

This is actually correct, because the library gives the HDOP in "hundredths". And because 100/10 == 1*10, this is in fact correct.