jpmml / jpmml-converter

Java library for authoring PMML
GNU Affero General Public License v3.0
15 stars 4 forks source link

fix pom guava version #14

Closed dan-ash closed 4 years ago

dan-ash commented 4 years ago

While trying to build a project with JPMML SkLearn I'm failing to build the dependencies with bazel-deps due to wrong version in the pom file, I would really appreciate if you can fix this by merging the PR and publish the package to maven for all it's versions that are affected

vruusmann commented 4 years ago

Sorry, this range-based version specification is very much intentional.

The JPMML-Converter library is a very low-level component, and needs to be included into a wide variety of middle- and high-level components that have their own Guava version requirements.

Why do you need to build JPMML-SkLearn in the first place? There's always an up-to-date version of it available in the Maven Central repository.

Also, WTF is bazel-deps? Perhaps, if this tool is broken (can't handle basic build stuff like range-based versions), then perhaps you should patch it instead.

dan-ash commented 4 years ago

thank you for your answer, my lack of understanding of the maven versioning syntax, caused my to think it's a bug. if you know about bazel then bazel-deps is a tool that generate bazel dependencies transitively for maven artifacts, with scala support. it seem that you right about what you said in the end of your comment. I'm trying to migrate a large scala project built with SBT to bazel