search

jpmml / jpmml-lightgbm

Java library and command-line application for converting LightGBM models to PMML
GNU Affero General Public License v3.0
174 stars 58 forks source link

Broken tests #6

Closed Goorman closed 6 years ago

Goorman commented 7 years ago

Trying to build this library according to manual, it builds fine but fails to pass classifier tests:

screen shot 2017-11-08 at 14 07 40

org.jpmml.lightgbm.ClassificationTest.txt

Built it with -Dskiptests flag for now, but this is probably something you would want to fix.

OS: mac os 10.13

P.S: Since the difference is in 15th digit or something like that, you could check not for exact equality but for approximate equality with small tolerance 1e-10.

vruusmann commented 6 years ago

The build succeeds using Java 1.7 and 1.8 on 64-bit LInux.

The "aspiration" for exact reproducibility between LightGBM and (J)PMML predictions is intentional - this helps me to detect regressions during version updates/upgrades.