search

jpmml / jpmml-r

Java library and command-line application for converting R models to PMML
GNU Affero General Public License v3.0
33 stars 8 forks source link

Could org.jpmml:jpmml-r:1.4-SNAPSHOT drop off redundant dependencies to loose weight? #15

Closed Celebrate-future closed 3 years ago

Celebrate-future commented 3 years ago

@vruusmann Hi, I am a user of project org.jpmml:jpmml-r:1.4-SNAPSHOT. I found that its pom file introduced 29 dependencies. However, among them, 4 libraries (13%) have not been used by your project (the redundant dependencies are listed below). Reduce these useless dependencies can help prevent conflicts between library versions. MeanWhile, it can minimize the total added size to projects. It can also help enable advanced scenarios for users of your package. This PR helps org.jpmml:jpmml-r:1.4-SNAPSHOT lose weight :) I have tested the revised configuration in my local environment. It is safe to remove the unused libraries.

Best regards

Redundant dependencies----


com.sun.activation:jakarta.activation:jar:1.2.2:runtime
org.jpmml:pmml-agent:jar:1.5.11:compile
org.glassfish.jaxb:jaxb-runtime:jar:2.3.3:compile
com.sun.istack:istack-commons-runtime:jar:3.0.11:compile
vruusmann commented 3 years ago

The build is Java version dependent.

If these dependencies are excluded, then the build will fail with Java 9 and newer (that don't include a JAXB runtime by default).