jpmml / jpmml-sklearn

Java library and command-line application for converting Scikit-Learn pipelines to PMML
GNU Affero General Public License v3.0
531 stars 117 forks source link

Harden the `MiningSchema` element of ensemble models #171

Closed vruusmann closed 2 years ago

vruusmann commented 2 years ago

Example: https://github.com/jpmml/jpmml-evaluator/issues/237

Specifically, should add checks that:

  1. Missing values can't enter the model body.
  2. The Output element can't perform transformations on a missing prediction.
  3. One model segment can't pass a missing value to another segment.

Currently, specifying Segmenttation@missingPredictionTreatment="returnMissing" doesn't seem to suffice.

vruusmann commented 2 years ago

The evaluator side of this issue was refactored in https://github.com/jpmml/jpmml-evaluator/commit/9e94081d29283254dd738a727de2707974c53442 (included in JPMML-Evaluator 1.6.4 and newer).