search

jpmml / jpmml-sklearn

Java library and command-line application for converting Scikit-Learn pipelines to PMML
GNU Affero General Public License v3.0
531 stars 117 forks source link

scikit-learn version #193

Closed dfarren closed 7 months ago

dfarren commented 7 months ago

Hello everyone. Just one comment and a question:

The readme file shows a dependency for scikit-learn 0.16.0 or newer. However, the code checks for scikit-version less or equal to 1.3.2.

Are there any plans to support later scikit-learn versions?

Thanks

vruusmann commented 7 months ago

The readme file shows a dependency for scikit-learn 0.16.0 or newer. However, the code checks for scikit-version less or equal to 1.3.2.

All correct - these are the lower and upper bounds of supported Scikit-Learn versions. In other words, the JPMML-SkLearn library should be able to parse and convert any Pickle file that has been produced over the past ~eight years, using Scikit-Learn version 0.16.X -- 1.3.X. Beat that!

Are there any plans to support later scikit-learn versions?

Most definitely.

The support for Scikit-Learn 1.4.X is currently not available, because Scikit-Learn developers broke the Pipeline._fit(X, y) method signature. See https://github.com/jpmml/sklearn2pmml/issues/409