search

jpmml / jpmml-sklearn

Java library and command-line application for converting Scikit-Learn pipelines to PMML
GNU Affero General Public License v3.0
531 stars 117 forks source link

Adding `scikit-learn~=1.4.x` support #195

Closed rahul-theorem closed 6 months ago

rahul-theorem commented 6 months ago

We recently upgraded scikit-learn to 1.4.1.post1, and are now adding support for saving PMML models and encountered this error:

Exception in thread "main" java.lang.IllegalArgumentException: This converter version does not know about Scikit-Learn version 1.4.1.post1 artifacts. Please upgrade the converter to the latest version, or downgrade Scikit-Learn to version 1.3.2

What would it take to relax the assumption in https://github.com/jpmml/jpmml-sklearn/blob/08bd610c84fa4db6613ea34429b3472b47790580/pmml-sklearn/src/main/java/sklearn/Step.java#L40 to 1.4.x / is there a particular process here? Happy to help get this change in / adopted in sklearn2pmml