search

jpmml / jpmml-sklearn

Java library and command-line application for converting Scikit-Learn pipelines to PMML
GNU Affero General Public License v3.0
531 stars 117 forks source link

enable Reproducible Builds #197

Closed hboutemy closed 5 months ago

hboutemy commented 5 months ago

see https://maven.apache.org/guides/mini/guide-reproducible-builds.html

hboutemy commented 5 months ago

success!!! https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/jpmml/jpmml-sklearn/README.md

notice that adding the property in each pom 689d6ee06e9fdb9e46d9d13f8a616a386dea46cb was not useful: parent is sufficient you've been hit by a bug in maven-artifact-plugin that will be solved in next release (in progress) https://issues.apache.org/jira/browse/MARTIFACT-54

vruusmann commented 5 months ago

notice that adding the property in each pom https://github.com/jpmml/jpmml-sklearn/commit/689d6ee06e9fdb9e46d9d13f8a616a386dea46cb was not useful: parent is sufficient

I was following the advice of mvn artifact:check-buildplan with that one.

Didn't like such metadata repetition too much (as all other metadata seems to be freely inheritable from the parent POM to child POMs). Glad to know that it can be resolved soon.

Also, I've been completely unaware of https://reproducible-builds.org/ so far. Thanks for showing it to me!