search

jpmorganchase / QOKit

QOKit
https://www.jpmorgan.com/technology/applied-research
Apache License 2.0
52 stars 23 forks source link

fixed cuda simulator break #37

Closed rajgane07 closed 9 months ago

rajgane07 commented 9 months ago

@rsln-s - I have done hot fix and all test cases passes. Suddenly upload to pypi test for wheel build is failing for windows, but source build succeeds . This is a weird error. I think this gh action issue. I will look into it. Probably this will go away after I run it sometime. Can you please check in GPU machine if the coda code works now?

rsln-s commented 9 months ago

@HaoTy, would you mind checking as well since you're the one who reported the issue?

rsln-s commented 9 months ago

Tests pass for me on a GPU instance. The change in qokit/fur/mpi_nbcuda/qaoa_simulator.py may still be incorrect as that functionality is not covered by tests.

rajgane07 commented 9 months ago

@HaoTy

Can we have quick call on Monday? I do not have access to GPU instance, would like to see what you are seeing and what is expected to have better understanding of issues. The optimization type is passed from each problem and based on the problem the it is calculated for maximization and minimization.

HaoTy commented 9 months ago

Can we have quick call on Monday?

Sure, just send me a Zoom link. I'm available after 2 pm Eastern time.

rajgane07 commented 9 months ago

@rsln-s @HaoTy I made the changes, I will try to test this in OmniAI by tomorrow. Can you also test from your side?

rajgane07 commented 9 months ago

@rsln-s @HaoTy I have resolved the issue and tested cuda simulator and python simulator in Omni AI. It gives me consistent results.

Can you please test from your end? If everthing works, review and merge the code

rsln-s commented 9 months ago

The tests pass for me on a GPU instance. @HaoTy, would you mind approving the PR with the latest changes if it looks good to you, or otherwise commenting on any outstanding issues?