search

jpmorganchase / QOKit

QOKit
https://www.jpmorgan.com/technology/applied-research
Apache License 2.0
46 stars 21 forks source link

Issue#38 - Flip Order of Gamma and Beta #48

Closed rajgane07 closed 5 months ago

rajgane07 commented 5 months ago

@rsln-s @ZichangHe

Made changes and tested. Please review and merge

rsln-s commented 5 months ago

@ZichangHe would you mind reviewing? Thank you!

ZichangHe commented 5 months ago

I fixed some inconsistent issues in the example notebooks. Otherwise, looks good to me!

A quick question, how to restore outputs in jupyter notebooks?

rsln-s commented 5 months ago

A quick question, how to restore outputs in jupyter notebooks?

On OmniQ, you can delete hooks: 

cd QOKit
rm .git/hooks/*
ZichangHe commented 5 months ago

Fixed the two minor change.