search

jpmorganchase / nbcelltests

Cell-by-cell testing for production Jupyter notebooks in JupyterLab
Apache License 2.0
90 stars 21 forks source link

Increase default timeout for running cell tests #211

Open ceball opened 4 years ago

ceball commented 4 years ago

Currently, once you click to run cell tests in jupyter lab, the result needs to come back within 5 seconds or it'll be cancelled.

But even if all heavy parts of a notebook are mocked out, many a notebook's celltests will not complete in 5 seconds.

We should probably up the default to 15 seconds or so.

https://github.com/jpmorganchase/nbcelltests/blob/fa86221569181e9ebdac9322cdd6dcc64b833923/js/src/run.ts#L15

https://github.com/jpmorganchase/nbcelltests/blob/fa86221569181e9ebdac9322cdd6dcc64b833923/js/src/run.ts#L35

https://github.com/timkpaine/requests-helper/blob/master/src/index.ts#L21

That should be easy.

We could also consider making that configurable.

However, it might be better to focus on improving how celltests are launched: #210

vidartf commented 4 years ago

I think this is an artifact of the current UX. With a better UX, we could up the timeout a lot (and make it a setting), and instead ensure that the user is able to cancel the test run e.g. by pressing a button.