search

jpmorganchase / py-avro-schema

Generate Apache Avro schemas for Python types including standard library data-classes and Pydantic data models.
https://py-avro-schema.readthedocs.io/
Apache License 2.0
37 stars 6 forks source link

[MINOR] allow to render schema record names by alias for pydantic #54

Closed dada-engineer closed 1 year ago

dada-engineer commented 1 year ago

Fixes #53

faph commented 1 year ago

I like it. Thanks!

faph commented 1 year ago

I am afraid I have to ask this, would you mind completing the CLA @dabdada if you have not done so yet? See https://github.com/jpmorganchase/.github/blob/main/CONTRIBUTING.md and https://github.com/jpmorganchase/.github/blob/main/jpmc-cla-20230406.md

faph commented 1 year ago

Adding [MINOR] prefix to PR title to indicate this would be released under version 3.1.0

dada-engineer commented 1 year ago

@faph adjusted according to your suggestions. Thanks. Will send the signed cla in a bit.

faph commented 1 year ago

@faph adjusted according to your suggestions. Thanks. Will send the signed cla in a bit.

Just confirm when done so I can merge this.

dada-engineer commented 1 year ago

@faph adjusted according to your suggestions. Thanks. Will send the signed cla in a bit.

Just confirm when done so I can merge this.

Done. Thank you.