search

jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customisation and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
111 stars 78 forks source link

Data Grid: Enable buttons to be placed into cells #1012

Open ZarkoPernar opened 1 year ago

ZarkoPernar commented 1 year ago

Area

UI Components

The problem

Currently, users can add both individual buttons and button groups to editable cells. We need to ensure there is sufficient documentation, story examples, and that the code makes sense for this use case.

The solution

Alternatives and examples

N/A

Are you a JPMorgan Chase & Co. employee?

### Tasks
- [ ] #1394
ZarkoPernar commented 1 year ago

After discussing this with Josh, we decided to make sure we showcase in storybook, and make clear in the documentation, that we currently only support a single button per column. Multiple buttons per columns will require a refactor of editable cells, and addition of an additional type of a cell which is a considerable piece of work. The single button on the other hand requires a minimal amount of code change.

parsakhan21 commented 1 year ago

March 28 - still addressing a bug on this ; create a new ticket to refactor. this is ok to close March 23 - awaiting reviews March 22 - awaiting reviews March 20 - on pause until validation complete March 17 - not in progress currently March 14 - another PR to close out - discussions first to ensure this is the path to move fwd with March 13 - addressing feedback today March 1- awaiting reviews Feb 28 - awaiting dev review Feb 17 - awaiting dev review - josh Feb 16 - awaiting dev review - Josh 2/15 - awaiting dev review - josh 2/14 - requires dev reviews 2/13 - working on tests now; stella can take a look at this when she can 2/9 - Josh to review 2/8 - update that Josh needs to review (Zarko to add to PR)

joshwooding commented 1 year ago

Discussion to happen today on Tooltip issues, that are blocking this

ZarkoPernar commented 1 year ago

I have now removed the Tooltip from the example because in its current form does not work inside grid, and the bug I mentioned in yesterday's standup was related to the tooltip. I have refactored the story and should now be done.

parsakhan21 commented 1 year ago

So, can this issue be marked as "done" or pulled back "in progress"?

fyi @joshwooding

ZarkoPernar commented 1 year ago

I found more issues with the naive approach attempted in #1036. I suggest we close the PR and focus on redesigning the approach to interact-able cells first. cc @parsakhan21