Closed joshwooding closed 7 months ago
11 Sep - initial design review requested for figma component (spacing etc) @bhoppers2008 @dplsek
Moving to blocked, work still need to be reviewed
Removed the target date due to it being blocked
Moving priority, pending design review
Design review next week, aiming for ready to dev the sprint after next
@origami-z Nav is going to move this item forwards and make sure design decisions are made so we can get it in a state for dev. With that in mind, presuming we can make those decisions by end of week, what target date can we give this component? @navkaur76
Moving this top of backlog. If dev has spare capacity next week, we can pick this up. Or will be the one after next. Temporarily setting to 27 Oct.
25 Oct - pending design review @bhoppers2008 23 Oct - in design review
Pushing out target date, so get enough dev time after design review
Push out date to include dev delivery time.
@bhoppers2008 working on completing the design work
3 Nov - further design changes needed, expect to finish EOD
@bhoppers2008 - specs to be ready by EOD.
@feliciackh reviewing the specs and doing investigation into how other similar components are built. Target date moved to next week.
13 Nov - WIP, talked with @joshwooding last week.
17 Nov - @feliciackh working on other priorities (Theme 1.0, UITK font feedback). Push to amber. Dev Component started, focus trap to be the main focus.
20 Nov - working on CSS, focus manager, tests, examples.
22 Nov - refactored component to use FloatingComponent to enable desktop use, floating focus manager needs reworking due to refactor
27 Nov - wip on focus manager, going to refactor Floating Component to include Focus Manager.
27/28 Nov - found a misbehavior with FloatingFocusManager
, issue raised in Floating UI's github. To continue development assuming focus behavior works correctly
30 Nov - GH PR pending more reviews. Component updated to have focus move into floating element on trigger element press. Previously focus remains on trigger element on trigger element press. Behaviour to be discussed with @bhoppers2008 on Friday Dec 1
1 Dec - PR ready, pending design review. Doc PR is separate.
Overlay doc issue: https://github.com/jpmorganchase/salt-ds/issues/2807. Please refer to email for link to Word doc cc @bhoppers2008 @mikearildbrown
4 Dec - PR review, dev to be taken from @feliciackh while OOO
6 Dec - handover needs to picked up.
18 Dec - Working through feedback on the PR. Pinged @bhoppers2008 and @mikearildbrown on the docs.
@bhoppers2008 will be done by tomorrow morning @feliciackh to cherry-pick examples from Storybook to the site and will sent the latest link
20 Dec - Design feedback addressed, had a catch up with @joshwooding. Working on some small changes and then will move to an API refactor
09/01 - Working on getting a RC ready. Working on changes needed after the floating-ui update. The docs have been updated.
Figma Spec: https://www.figma.com/file/hFCYdor9r1AefRvLPuthMm/Overlay
Questions: