jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
132 stars 90 forks source link

Overlay #1051

Closed joshwooding closed 7 months ago

joshwooding commented 1 year ago

Figma Spec: https://www.figma.com/file/hFCYdor9r1AefRvLPuthMm/Overlay

### Checklist
- [ ] Density (HD, MD, LD, TD)
- [ ] Mode (Light, Dark)
- [ ] Fill (Primary, Secondary, Tertiary)
- [ ] State (Default, Hover, Selected/Active, Disabled, Read-only, Other)
- [ ] Controlled API
- [ ] UITK accessibility parity (screen reader + keyboard interactions)
### Deliverables
- [ ] Characteristics spec
- [ ] Interactions spec, where necessary
- [ ] In Code & Figma (Component + Guide)
- [ ] https://github.com/jpmorganchase/salt-ds/issues/2807
### Features
- [x] Appear on click/trigger
- [x] Support positioning top/left/right/bottom
- [x] Close with internal close button

Questions:

navkaur76 commented 1 year ago

11 Sep - initial design review requested for figma component (spacing etc) @bhoppers2008 @dplsek

joshwooding commented 1 year ago

Moving to blocked, work still need to be reviewed

joshwooding commented 1 year ago

Removed the target date due to it being blocked

origami-z commented 1 year ago

Moving priority, pending design review

Design review next week, aiming for ready to dev the sprint after next

bhoppers2008 commented 1 year ago

@origami-z Nav is going to move this item forwards and make sure design decisions are made so we can get it in a state for dev. With that in mind, presuming we can make those decisions by end of week, what target date can we give this component? @navkaur76

origami-z commented 1 year ago

Moving this top of backlog. If dev has spare capacity next week, we can pick this up. Or will be the one after next. Temporarily setting to 27 Oct.

origami-z commented 1 year ago

25 Oct - pending design review @bhoppers2008 23 Oct - in design review

origami-z commented 1 year ago

Pushing out target date, so get enough dev time after design review

origami-z commented 1 year ago

Push out date to include dev delivery time.

joshwooding commented 1 year ago

@bhoppers2008 working on completing the design work

origami-z commented 1 year ago

3 Nov - further design changes needed, expect to finish EOD

shey-v commented 1 year ago

@bhoppers2008 - specs to be ready by EOD.

joshwooding commented 1 year ago

@feliciackh reviewing the specs and doing investigation into how other similar components are built. Target date moved to next week.

origami-z commented 1 year ago

13 Nov - WIP, talked with @joshwooding last week.

origami-z commented 12 months ago

17 Nov - @feliciackh working on other priorities (Theme 1.0, UITK font feedback). Push to amber. Dev Component started, focus trap to be the main focus.

origami-z commented 12 months ago

20 Nov - working on CSS, focus manager, tests, examples.

feliciackh commented 11 months ago

22 Nov - refactored component to use FloatingComponent to enable desktop use, floating focus manager needs reworking due to refactor

origami-z commented 11 months ago

27 Nov - wip on focus manager, going to refactor Floating Component to include Focus Manager.

feliciackh commented 11 months ago

27/28 Nov - found a misbehavior with FloatingFocusManager, issue raised in Floating UI's github. To continue development assuming focus behavior works correctly

feliciackh commented 11 months ago

30 Nov - GH PR pending more reviews. Component updated to have focus move into floating element on trigger element press. Previously focus remains on trigger element on trigger element press. Behaviour to be discussed with @bhoppers2008 on Friday Dec 1

origami-z commented 11 months ago

1 Dec - PR ready, pending design review. Doc PR is separate.

feliciackh commented 11 months ago

Overlay doc issue: https://github.com/jpmorganchase/salt-ds/issues/2807. Please refer to email for link to Word doc cc @bhoppers2008 @mikearildbrown

origami-z commented 11 months ago

4 Dec - PR review, dev to be taken from @feliciackh while OOO

origami-z commented 11 months ago

6 Dec - handover needs to picked up.

joshwooding commented 11 months ago

18 Dec - Working through feedback on the PR. Pinged @bhoppers2008 and @mikearildbrown on the docs.

@bhoppers2008 will be done by tomorrow morning @feliciackh to cherry-pick examples from Storybook to the site and will sent the latest link

joshwooding commented 11 months ago

20 Dec - Design feedback addressed, had a catch up with @joshwooding. Working on some small changes and then will move to an API refactor

joshwooding commented 10 months ago

09/01 - Working on getting a RC ready. Working on changes needed after the floating-ui update. The docs have been updated.