search

jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
120 stars 88 forks source link

Future Breaking Changes #1107

Open joshwooding opened 1 year ago

joshwooding commented 1 year ago

This is an umbrella issue to track changes for v2.

### Breaking Changes - AG-Grid Theme
- [ ] Remove `.editable-numeric-cell`
### Breaking Changes - Core
- [ ] Remove `separators` prop from `FlexLayout`
- [ ] #1335
- [ ] Card `interactive` prop
- [ ] Default style injection to false #2532
- [ ] Navigation Item: Remove wrapping `<div/>` so that NavigationItem renders either a `<button\>` or `<anchor/>`, this will enable us to pass `...rest` to the actual `<button\>` or `<anchor/>`, rather than to the wrapping `<div/>`. The breaking change is the Typescript types and the `ref`, which currently a `<div/>` . This change is now possible due to us adding a more customisable API through the `render` prop. #3417
- [ ] Remove `UNSTABLE_` backwards compatibility
### Breaking Changes - Theme
- [ ] Remove deprecated tokens
el-dav commented 1 year ago

I'd suggest removing the responsive behaviour that's built into layout components when we're doing V2. Alternative could be the spike I did on responsive props where consumers can wrap any component to make it responsive.