jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
128 stars 89 forks source link

Responsive Props #1156

Open el-dav opened 1 year ago

el-dav commented 1 year ago

Investigate a solution for responsive props within the design system.

Responsive props make it convenient for consumers to adapt their applications to different screen sizes.

We should include something within Salt to make this easy for consumers to improve consistency within applications e.g. making sure size changes happen at consistent breakpoints.

Currently we have incorporated responsive props into a few Layout components but not consistently and there are other properties e.g. the size of Avatar and Icon which may also want to adapt

el-dav commented 1 year ago

Following discussion between the devs I'm investigating providing a few hooks and components which can be used to adapt existing components to be responsive, rather than bake the logic into each component individually. This should give consumers more flexibility, including allowing them to make their own components responsive. It will also reduce the overhead where consumers don't need the responsive behaviour

el-dav commented 1 year ago

Feb 17 - no update, will do an all team demo Feb 16 - reviewed with devs - think about if we add to salt - tbd (do an all team demo show for awareness) Feb 15 - Created the following PR with an initial implementation to get comments from the rest of the team: https://github.com/jpmorganchase/salt-ds/pull/1158 - awaiting review