search

jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customisation and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
111 stars 78 forks source link

Carousel not rendering children width correctly #2558

Closed origami-z closed 2 hours ago

origami-z commented 9 months ago

Package name(s)

Lab (@salt-ds/lab)

Package version(s)

1.0.0-alpha.18

Description

Carousel is not having correct width in respect to children's width [timebox 1d]

Steps to reproduce

https://stackblitz.com/edit/salt-template-pk7j3b?file=App.tsx,package.json,style.css

Expected behavior

Carousel should take CarouselSlide's width as default width

Operating system

Browser

Are you a JPMorgan Chase & Co. employee?

mark-tate commented 8 months ago

This is a bug in DeckLayout but surfaced in Carousel

mark-tate commented 8 months ago

@ZarkoPernar Need to find out if MCP need this and if not we can lower the priority and move back to the backlog.

ZarkoPernar commented 8 months ago

@mark-tate I think it's pretty important for mcp

mark-tate commented 2 hours ago

Will pick this up when we revisit deck layout

mark-tate commented 2 hours ago

Will pick this up when we revisit deck layout