PillNext has inconsistent text styles that lead to misalignment of icons and clipping of descenders - Githubissues

jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use

https://www.saltdesignsystem.com

Apache License 2.0

128 stars 90 forks source link

PillNext has inconsistent text styles that lead to misalignment of icons and clipping of descenders #2667

Closed joshwooding closed 9 months ago

joshwooding commented 11 months ago

Package name(s)

Lab (@salt-ds/lab)

Package version(s)

Latest

Description

PillNext has inconsistent text styles that lead to misaligned icons and clipping of descenders.

Steps to reproduce

Visit https://storybook.saltdesignsystem.com/?path=/story/lab-pill-next-qa--examples-grid

Expected behavior

It not to be misaligned

Operating system

[ ] macOS
[ ] Windows
[ ] Linux
[ ] iOS
[ ] Android

Browser

[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

Are you a JPMorgan Chase & Co. employee?

[X] I am an employee of JPMorgan Chase & Co.

joshwooding commented 11 months ago

As @Fercas123 is already working on PillNext she has volunteered to fix this :)

lilyvc commented 9 months ago

I think this looks fixed now