Whilst reviewing data grid updates inconsistencies were found between the size of the cell corner flag in figma and what we have as tokens in code. Mainly… we don’t have a token to match what we have in code.
Use of different tokens was explored explored using existing tokens to size the flag but --size-icon didn’t feel semantically correct and --size-adornment gives limited affordance, especially in hd-compact and hd.
That led to considering where we are using --size-adornment.
This issue will address three actions:
Rename --size-adornment to --size-modifier.
Update --size-modifier values from 6,8,10,12 to 8,10,12,14 (to offer improved affordance and standardisation).
Update components using --size-modifier.
Specific component features affected for #3 are:
Data Grid editable cell corner flag: Size
Data Grid RAG (error, warning, success) icons: Size and position
First column of grids is hd-compact.
Left grouping is the proposal, right is whats currently available.
I’ve illustrated how these would apply to Calendar, but this will be picked up in Calendar work which is currently WIP.
Whilst reviewing data grid updates inconsistencies were found between the size of the cell corner flag in figma and what we have as tokens in code. Mainly… we don’t have a token to match what we have in code.
Use of different tokens was explored explored using existing tokens to size the flag but
--size-icon
didn’t feel semantically correct and--size-adornment
gives limited affordance, especially in hd-compact and hd.That led to considering where we are using
--size-adornment
.This issue will address three actions:
--size-adornment
to--size-modifier
.--size-modifier
values from 6,8,10,12 to 8,10,12,14 (to offer improved affordance and standardisation).--size-modifier
.Specific component features affected for #3 are:
The result of updates are documented here.
Notes:
First column of grids is hd-compact. Left grouping is the proposal, right is whats currently available. I’ve illustrated how these would apply to Calendar, but this will be picked up in Calendar work which is currently WIP.