Disabled Toggle Button Group should show selected value

jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use

https://www.saltdesignsystem.com

Apache License 2.0

132 stars 89 forks source link

Disabled Toggle Button Group should show selected value #3075

Open origami-z opened 9 months ago

origami-z commented 9 months ago

Package name(s)

Core (@salt-ds/core)

Package version(s)

1.16.0

Description

Selected one doesn't show up when the group is disabled

Steps to reproduce

https://stackblitz.com/edit/salt-template-wukdsv?file=App.tsx,package.json

Expected behavior

No response

Operating system

[X] macOS
[ ] Windows
[ ] Linux
[ ] iOS
[ ] Android

Browser

[X] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

Are you a JPMorgan Chase & Co. employee?

[X] I am an employee of JPMorgan Chase & Co.

joshwooding commented 9 months ago

This will need design input @jpmorganchase/salt-design-lead. Currently ToggleButton follows the spec and we don't have a token available

origami-z commented 2 months ago

+1 from community, SO 91811

mark-tate commented 2 months ago

design needs to add new tokens to support this, then a small dev task We have a related task that needs to update Toggle button, so will pickup this work through that

joshwooding commented 2 months ago

Re-worded this as an enhancement as it currently meets the spec so isn't a bug