If --salt-palette-corner-weak value in theme changes, Checkbox visual is off - Githubissues

jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customisation and ease-of-use

https://www.saltdesignsystem.com

Apache License 2.0

111 stars 78 forks source link

If --salt-palette-corner-weak value in theme changes, Checkbox visual is off #3248

Open libertymayc opened 2 months ago

libertymayc commented 2 months ago

Package name(s)

Core (@salt-ds/core), Theme (@salt-ds/theme)

Package version(s)

theme-next corner

Description

If you were to make the radius of --salt-palette-corner-weaker larger in Checkbox, the inner SVG visual is off when checked

Screenshot 2024-04-12 at 1 58 54 PM

Steps to reproduce

No response

Expected behavior

add border radius to inner SVG as well

Operating system

[X] macOS
[ ] Windows
[ ] Linux
[ ] iOS
[ ] Android

Browser

[X] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

Are you a JPMorgan Chase & Co. employee?

[X] I am an employee of JPMorgan Chase & Co.

joshwooding commented 2 months ago

I don't believe we are allowing this sort of change, the intended use is to toggle the corner type from sharp to rounded but we'll need someone from @jpmorganchase/salt-design to comment