System Status design - Githubissues

jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customisation and ease-of-use

https://www.saltdesignsystem.com

Apache License 2.0

111 stars 78 forks source link

Closed bhoppers2008 closed 18 hours ago

bhoppers2008 commented 2 months ago

Salt and Pepper to collaborate on single solution for system banner using Salt Banner component.

pseys commented 2 weeks ago

Agreement to add the following tokens and variables to support System Status styling:

A foreground token/variable is also needed. The new token is also needed for #3325 . The new foreground token is:

pseys commented 2 weeks ago

The new tokens have been added to Salt (Next) Styles library as variables, the updates have been published ready for use
The new tokens have been added to Salt Light mode library as styles, the updates have been published ready for use
The new tokens have been added to Salt Dark mode library as styles, the updates have been published ready for use
The Theme Characteristics file has been updated to document the changes to Salt Light/Dark mode libraries.

mark-tate commented 2 weeks ago

Zazu Goal: S(3)

shey-v commented 1 week ago

Shey and Thurshara discussed the approach to build the system status component.
Thushara will build the component and prepare site documentation according to Shey's Figma specs.
Shey will prepare the Figma component in the current and next libraries.
The component has a dependency on the status button, so some site examples will be incomplete until the status button can be added.

Note: Update the site examples when the status button is ready.

shey-v commented 5 days ago

QA in progress; there is an issue with the PR build, Thurshara has asked Josh to fix it so that Shey can design QA the site docs
Thushara is adding one more example to storybook and the site around 'full width' which Josh and Shey requested yesterday
Shey to create a seperate ticket to add the status button in to the component (figma and code) when it is available.

shey-v commented 18 hours ago

Design QA done, all issues raised have now been addressed.
Ticket to add status button into the component when it is ready has been created here.