jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
112 stars 83 forks source link

Notification dot badge design #3321

Closed bhoppers2008 closed 13 hours ago

bhoppers2008 commented 2 months ago

Design spec required for dot badge.

### Tasks
- [x] Characteristic spec: Salt 1
- [x] Characteristic spec: Salt Next
- [x] Site Examples
- [x] Accessibility spec
- [x] Interactions spec
- [x] Figma Components: Salt 1 Light
- [x] Figma Components: Salt 1 Dark
- [x] Figma Components: Salt Next
- [x] Figma componrnt guide
yunjungyeh commented 3 weeks ago

Kick-off scheduled on Thursday 27 June

mark-tate commented 3 weeks ago

Kickoff on Thur Goal: M(5) ready for Dev by ?

yunjungyeh commented 3 weeks ago

Dot Badge KO notes:

Team

  1. Core design: Yun
  2. Dev reference point (during dev): Josh
  3. Development: Pepper devs (Thushara/ Vineet)

Size/Delivery

  1. To core by end of Americano.

    What is the capacity of the team (design/developers) picking up the issue. i. Pepper devs busy for remainder of Zazu. ii. Preheader design (update preheader spec + add to component) – @bhoppers2008 to start iii. Preheader dev (identify bug fix and add to backlog).

  2. Do we have a reviewer (in Pepper/CB) that could feedback (Asmita to clarify).

    Additional feature to something we know works already/in core – RC not essential.

What is a Dot Badge?

  1. Initial problem statement: Notifies application users of… changes in state that user needs to be aware of (where a count or notation may not be possible/necessary).
    • (What is it about dot badge that makes it distinct from badge?)
    • Dot Badge is not for status/ categorisation/ presence – would be an alternative component variant.
  2. Pepper badge red – is it wired up to the accent/brand color? Does it need to be red (atm Pepper semantically tie it to error-red) Asmita to clarify?
  3. Neutral variant is out of scope (for a later PR).

Tech expectation

  1. Badge without content
    • Note: This could affect delivery teams using a badge with no content – Salt to test.
  2. Possible animation when displayed

Examples

  1. Surface examples from Pepper that we can design/build/test/document around
yunjungyeh commented 2 weeks ago

Tue 2 Jul - Reached out to LOB team, discussed size with @joshwooding (--salt-size-adornment), characteristic spec WIP

yunjungyeh commented 2 weeks ago

Wed 3 Jul - Discussed Positioning Options for both Badge and Badge Dot with @joshwooding @bhoppers2008 @dplsek, WIP

mark-tate commented 2 weeks ago

Goal: ready for dev by EOS

yunjungyeh commented 1 week ago

Thu 11 Jul - Characteristics/Interaction specs, component sets for both Salt 1 and Salt Next waiting to be reviewed

yunjungyeh commented 1 week ago

Fri 12 Jul

Reviewed with @joshwooding

Reviewed with @bhoppers2008

yunjungyeh commented 5 days ago

Wed 17 Jul - Component sets in Salt 1 Light/Dark, Salt Next, and Component Guide are done and ready for Peer Review

yunjungyeh commented 3 days ago

Fri 19 July - @ivan-calderon Peer reviewed, Figma branches to be merged

yunjungyeh commented 13 hours ago

Ready for merge, Design QA for another issue #3787