Way to limit the max height of a combobox or dropdown list

jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customisation and ease-of-use

https://www.saltdesignsystem.com

Apache License 2.0

109 stars 78 forks source link

Way to limit the max height of a combobox or dropdown list #3333

Closed joshwooding closed 4 hours ago

joshwooding commented 2 months ago

Area

UI Components

The problem

There is no easy way to limit the max height of a combobox or dropdown list.

The current way is to target the "saltOptionList" class and apply a max-height directly.

The solution

Alternatives and examples

Are you a JPMorgan Chase & Co. employee?

[ ] I am an employee of JPMorgan Chase & Co.

origami-z commented 1 month ago

Extend dates to Xion, 1 sprint behind

mark-tate commented 1 week ago

Zazu Goal: S(3)

PR to be raised , docs only change

Fercas123 commented 1 week ago

Did a quick exploration, but pure selectors are not allowed in css modules, and moving the class up to the global would affect every optionList in the site which is not the intention. possible options are:

allowing additional attributes being passed (https://github.com/jpmorganchase/salt-ds/issues/3599)

needs approach discussion.

Fercas123 commented 4 days ago

notes from @jpmorganchase/salt-developer conversation on 01 July 24:

there is no current way of passing popperProps in any of the components that use portal
the preferred way wold be to increase composition to avoid adding props that pass down to portal.
current solution could be to document how to target the list in global so users can override, downside is that it will be a change affecting all lists.

TBD: More research about different approaches and follow up.

Fercas123 commented 5 hours ago

documentation change addressed as short term solution, needs long term solution.

joshwooding commented 4 hours ago

I think we should create a new issue for a long-term solution. There is a way and it's documented.

efriandika commented 4 hours ago

Hi @Fercas123 Which documentation did you refer to? I don't see any related information in this page: https://www.saltdesignsystem.com/salt/components/combo-box/usage

We also use this combobox in our application. Really interested in this solution.

origami-z commented 3 hours ago

Short term recommendation changed in #3728.

Long term solution to be investigated in #3599